Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show eyebrow and lock review button when user has no REVIEWER permission #97

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Sep 13, 2023

Depends on https://github.com/chromaui/chromatic/pull/7717

📦 Published PR as canary version: 0.0.73--canary.97.0da4dcd.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.73--canary.97.0da4dcd.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.73--canary.97.0da4dcd.0

@linear
Copy link

linear bot commented Sep 13, 2023

AP-3446 Don't show accept button if user doesn't have review permission

If the user has only VIEWER permission on the project, we should not show the accept button or grey it out.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this a bit confusing, I think maybe some tweaking of the code would help.

src/screens/VisualTests/BuildResults.tsx Outdated Show resolved Hide resolved
src/screens/VisualTests/BuildResults.tsx Outdated Show resolved Hide resolved
src/screens/VisualTests/VisualTests.stories.tsx Outdated Show resolved Hide resolved
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmeasday tmeasday merged commit 23ca833 into main Sep 14, 2023
3 checks passed
@tmeasday tmeasday deleted the ghengeveld/ap-3446-dont-show-accept-button-if-user-doesnt-have-review branch September 14, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants